Report metrics for suggest anomaly detector #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <gbinlong@amazon.com>
gaobinlong
requested review from
ohltyler,
kaituo,
jackiehanyang,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
|
@jackiehanyang ,please help to review this PR when you're available, thanks, this change doesn't target for 2.17. |
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
gaobinlong
commented
Sep 18, 2024
| if: failure() | ||
| with: | ||
| name: cypress-screenshots-${{ matrix.os }} | ||
| path: opensearch-dashboards-functional-test/cypress/screenshots | ||
|
|
||
| - name: Capture failure test video | ||
| uses: actions/upload-artifact@v1 | ||
| uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
Update the version to v4 to make sure the e2e test can run normally, if not the test throws deprecation error.
|
@gaobinlong thanks for the change! Just curious, besides this feedback button, are we collecting usage metrics for this flyout? For example, the number of detectors created via this flyout, or errors that occurred on this flyout. If not, do we have plans to add these business metrics? |
Thanks, except the feedback metrics, we already add |
jackiehanyang
approved these changes
Sep 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Add feedback button to the flyout of suggest anomaly detector Signed-off-by: gaobinlong <gbinlong@amazon.com> * Check feature flag before registering action to Discover page Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix url bug Signed-off-by: gaobinlong <gbinlong@amazon.com> * Remove unused dependency Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix e2e test failure Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> (cherry picked from commit 26b12d1)
jackiehanyang
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Add feedback button to the flyout of suggest anomaly detector Signed-off-by: gaobinlong <gbinlong@amazon.com> * Check feature flag before registering action to Discover page Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix url bug Signed-off-by: gaobinlong <gbinlong@amazon.com> * Remove unused dependency Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix e2e test failure Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> (cherry picked from commit 26b12d1) Co-authored-by: gaobinlong <gbinlong@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/anomaly-detection-dashboards-plugin
that referenced
this pull request
Oct 18, 2024
…pensearch-project#878) * Add feedback button to the flyout of suggest anomaly detector Signed-off-by: gaobinlong <gbinlong@amazon.com> * Check feature flag before registering action to Discover page Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix url bug Signed-off-by: gaobinlong <gbinlong@amazon.com> * Remove unused dependency Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix e2e test failure Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> (cherry picked from commit 26b12d1) Co-authored-by: gaobinlong <gbinlong@amazon.com>
jackiehanyang
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Add suggest anomaly detector action to discover page (#849) (#872) * Add generate anomaly detector action to discover page Signed-off-by: gaobinlong <gbinlong@amazon.com> * Add more test code and rename the file Signed-off-by: gaobinlong <gbinlong@amazon.com> * Modify flyout header Signed-off-by: gaobinlong <gbinlong@amazon.com> * Make the detectorName follow the convention Signed-off-by: gaobinlong <gbinlong@amazon.com> * Truncate the index pattern name if it's too long Signed-off-by: gaobinlong <gbinlong@amazon.com> * Move entry point to query editor Signed-off-by: gaobinlong <gbinlong@amazon.com> * Call the node API in dashboard-assistant plugin to generate parameters Refactor unit test code Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix test failure Signed-off-by: gaobinlong <gbinlong@amazon.com> * Revert the code format Signed-off-by: gaobinlong <gbinlong@amazon.com> * Remove some empty lines Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> (cherry picked from commit ec02b63) Co-authored-by: gaobinlong <gbinlong@amazon.com> * Report metrics for suggest anomaly detector (#876) (#878) * Add feedback button to the flyout of suggest anomaly detector Signed-off-by: gaobinlong <gbinlong@amazon.com> * Check feature flag before registering action to Discover page Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix url bug Signed-off-by: gaobinlong <gbinlong@amazon.com> * Remove unused dependency Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix e2e test failure Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> (cherry picked from commit 26b12d1) Co-authored-by: gaobinlong <gbinlong@amazon.com> * feat: update category (#883) (#884) (cherry picked from commit 9402888) Co-authored-by: SuZhou-Joe <suzhou@amazon.com> * Revert "Increment version to 2.17.1.0 (#881)" This reverts commit 33dfe2f. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: Zhou Su <>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a small enhancement for the suggest anomaly detector feature, we add feedback button to the flyout of suggest anomaly detector, when users click the button, it will call the metric report API in the core plugin usageCollection. And when LLM gives suggested parameters successfully, a
generatedmetric is reported, when the suggested detector is created, acreatedmetric is reported.Another change is that we check the feature flag before register the SuggestAnomalyDetector action to Discover, if the feature flag is disabled or the whole assistant capability is disabled, no action will be registered.
Some UI change:
Issues Resolved
#816
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.